Skip to content

CI: Pin more cython #54759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2023
Merged

CI: Pin more cython #54759

merged 5 commits into from
Aug 26, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added Build Library building on various platforms CI Continuous Integration labels Aug 25, 2023
@lithomas1 lithomas1 requested a review from mroeschke as a code owner August 25, 2023 17:38
@@ -234,7 +234,7 @@ jobs:
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.0.1 meson-python==0.13.1
python -m pip install --no-cache-dir versioneer[toml] cython numpy python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 pytest-asyncio>=0.17 hypothesis>=6.46.1
python -m pip install --no-cache-dir versioneer[toml] cython<3.0.1 numpy python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 pytest-asyncio>=0.17 hypothesis>=6.46.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might need to quote this. I think bash is interpreting 3.0.1 as a file

@mroeschke mroeschke added this to the 2.1 milestone Aug 25, 2023
@lithomas1 lithomas1 merged commit ce6aa67 into pandas-dev:main Aug 26, 2023
@lithomas1 lithomas1 deleted the pin-more-cython branch August 26, 2023 00:36
@lumberbot-app
Copy link

lumberbot-app bot commented Aug 26, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ce6aa67314546f15a90668ad95ea7af88d80036a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #54759: CI: Pin more cython'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-54759-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #54759 on branch 2.1.x (CI: Pin more cython)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lithomas1
Copy link
Member Author

@meeseeksdev backport 2.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 26, 2023
phofl pushed a commit that referenced this pull request Aug 26, 2023
Backport PR #54759: CI: Pin more cython

Co-authored-by: Thomas Li <[email protected]>
mroeschke added a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
* CI: Pin more cython

* Update actions-311-numpydev.yaml

* Update unit-tests.yml

* Update .github/workflows/unit-tests.yml

* Update .github/workflows/unit-tests.yml

---------

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants